Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Toradex Hardware Configuration Files #448

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hiagofranco
Copy link

Add necessary configuration files related to Toradex Hardware.

DisableSequence [
cset "name='Headphone Switch' off"
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall: Missing PCM device specifications (Values) ....

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the Value node, please let me know... thanks!

}

BootSequence [
cset "name='Headphone Volume' 50%"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall: If hardware supports volume control, it should be speciified e.g. using PlaybackMixerElem.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to the Value, please let me know, thanks!

@@ -0,0 +1,13 @@
# Use case configuration for Toradex Apalis iMX6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ucm2/NXP paths (like current NXP/iMX8 etc.). We prefer to store configurations for similar hardware in one place.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perexg : can you explain better what would you like? These UCM files are related to Toradex board, the actual sound card on these boards does not have much in common with NXP nor i.MX8 boards..

Or maybe you want the boards that use the fsl-asoc-card to be grouped together? How?

SectionDevice."Headphone" {
Comment "Headphone"

BootSequence [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall: BootSequence must be in top configuration files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

Add support for the Toradex Apalis Evaluation Board carrier board using
the NAU8822 audio codec.

Signed-off-by: Hiago De Franco <[email protected]>
Add support for the Toradex Apalis iMX8 system on module, using the
SGTL5000 audio codec.

Signed-off-by: Hiago De Franco <[email protected]>
Add support for the Toradex Apalis iMX6 system on module, using the
SGTL5000 audio codec.

Signed-off-by: Hiago De Franco <[email protected]>
Add support for the Toradex Colibri iMX8X system on module, using the
SGTL5000 audio codec.

Signed-off-by: Hiago De Franco <[email protected]>
Add support for the Toradex Colibri iMX7 system on module, using the
SGTL5000 audio codec.

Signed-off-by: Hiago De Franco <[email protected]>
Add support for the Toradex Colibri iMX6 system on module, using the
SGTL5000 audio codec.

Signed-off-by: Hiago De Franco <[email protected]>
Add support for the Toradex Verdin Dahlia carrier board, using the WM8904
audio codec.

Signed-off-by: Hiago De Franco <[email protected]>
Add support for the Toradex Verdin Development carrier board, using the
NAU8822 audio codec.

Signed-off-by: Hiago De Franco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants